diff options
| author | Shi Tian <shitian@cock.li> | 2023-06-25 05:38:33 +0000 |
|---|---|---|
| committer | Hiltjo Posthuma <hiltjo@codemadness.org> | 2023-06-25 11:59:06 +0200 |
| commit | 3a6d6d740110e6ee1b092d05ad746244eedabe4b (patch) | |
| tree | 647f374b1935e0f10915e787325021b0f48adf58 | |
| parent | ignore C1 control characters in UTF-8 mode (diff) | |
| download | st-3a6d6d740110e6ee1b092d05ad746244eedabe4b.tar.gz st-3a6d6d740110e6ee1b092d05ad746244eedabe4b.zip | |
Fix for wide character being incorrectly cleared on MODE_INSERT
Under insert mode, when inserting a normal character in front of
a wide character, the affected region is shifted to the right by
one cell. However, the empty cell is reset as if being a part of a
wide character, causing the following cell being mishandled as a
dummy cell.
To reproduce the bug:
printf '\033[4h' # set MODE_INSERT
printf 妳好
printf '\033[4D'
printf 'x'
printf '\033[4l\n'
| -rw-r--r-- | st.c | 4 |
1 files changed, 3 insertions, 1 deletions
| @@ -2471,8 +2471,10 @@ check_control_code: | |||
| 2471 | gp = &term.line[term.c.y][term.c.x]; | 2471 | gp = &term.line[term.c.y][term.c.x]; |
| 2472 | } | 2472 | } |
| 2473 | 2473 | ||
| 2474 | if (IS_SET(MODE_INSERT) && term.c.x+width < term.col) | 2474 | if (IS_SET(MODE_INSERT) && term.c.x+width < term.col) { |
| 2475 | memmove(gp+width, gp, (term.col - term.c.x - width) * sizeof(Glyph)); | 2475 | memmove(gp+width, gp, (term.col - term.c.x - width) * sizeof(Glyph)); |
| 2476 | gp->mode &= ~ATTR_WIDE; | ||
| 2477 | } | ||
| 2476 | 2478 | ||
| 2477 | if (term.c.x+width > term.col) { | 2479 | if (term.c.x+width > term.col) { |
| 2478 | tnewline(1); | 2480 | tnewline(1); |
