From 355d8efefc1650e9aca2c9f0c58c45dc48904ccb Mon Sep 17 00:00:00 2001 From: salmonik Date: Wed, 29 Apr 2026 14:43:19 +0200 Subject: proper context for settings Signed-off-by: salmonik --- cogs/utils/settings.py | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) (limited to 'cogs/utils') diff --git a/cogs/utils/settings.py b/cogs/utils/settings.py index 7146b6c..b1a585c 100644 --- a/cogs/utils/settings.py +++ b/cogs/utils/settings.py @@ -30,11 +30,10 @@ class Settings: } try: - conn = get_connection() - c = conn.cursor() - c.execute("SELECT key, value FROM settings") - rows = c.fetchall() - conn.close() + with get_connection() as conn: + c = conn.cursor() + c.execute("SELECT key, value FROM settings") + rows = c.fetchall() if rows: self._data = {row[0]: row[1] for row in rows} @@ -65,16 +64,15 @@ class Settings: async def save(self): self._sync_to_data() - conn = get_connection() - c = conn.cursor() - c.execute("PRAGMA foreign_keys = ON") - for key, value in self._data.items(): - c.execute( - "INSERT OR REPLACE INTO settings (key, value) VALUES (?, ?)", - (key, value), - ) - conn.commit() - conn.close() + with get_connection() as conn: + c = conn.cursor() + c.execute("PRAGMA foreign_keys = ON") + for key, value in self._data.items(): + c.execute( + "INSERT OR REPLACE INTO settings (key, value) VALUES (?, ?)", + (key, value), + ) + conn.commit() _settings_instance: Settings | None = None -- cgit v1.2.3