Clean up consumers: replace polling with VoiceManager.play_source()

- cron.py: replace while-is_playing polling with VoiceManager.play_source()
- vclogs.py: replace while-is_playing polling with VoiceManager.play_source()
- stop.py: use VoiceManager.disconnect() instead of raw voice_client
- join.py: use VoiceManager.connect() instead of raw channel.connect()
- voice.py: add back join_by_channel_id() convenience method
- Tests: update for new VoiceManager method names and signatures

1 files changed, 2 insertions, 2 deletions

diff --git a/tests/cogs/test_voice.py b/tests/cogs/test_voice.py
index 104eea6..6eb226b 100644
--- a/tests/cogs/test_voice.py
+++ b/tests/cogs/test_voice.py
@@ -53,7 +53,7 @@ async def test_voice_manager_get_voice_status_not_connected():
     mock_bot = MagicMock()
     mock_guild = MagicMock()
 
-    with patch('cogs.voice.VoiceManager.get_voice_client', return_value=None):
+    with patch('cogs.voice.VoiceManager.get_client', return_value=None):
         manager = VoiceManager(mock_bot)
         voice_client, is_connected, is_playing = await manager.get_voice_status(mock_guild)
 
@@ -71,7 +71,7 @@ async def test_voice_manager_stop():
     mock_voice_client = MagicMock()
     mock_voice_client.disconnect = AsyncMock()
 
-    with patch('cogs.voice.VoiceManager.get_voice_client', return_value=mock_voice_client):
+    with patch('cogs.voice.VoiceManager.get_client', return_value=mock_voice_client):
         manager = VoiceManager(mock_bot)
         await manager.stop(mock_guild)