Clean up consumers: replace polling with VoiceManager.play_source()

- cron.py: replace while-is_playing polling with VoiceManager.play_source()
- vclogs.py: replace while-is_playing polling with VoiceManager.play_source()
- stop.py: use VoiceManager.disconnect() instead of raw voice_client
- join.py: use VoiceManager.connect() instead of raw channel.connect()
- voice.py: add back join_by_channel_id() convenience method
- Tests: update for new VoiceManager method names and signatures

1 files changed, 4 insertions, 1 deletions

diff --git a/cogs/music/stop.py b/cogs/music/stop.py
index f06e7f5..9c8d5cf 100644
--- a/cogs/music/stop.py
+++ b/cogs/music/stop.py
@@ -5,6 +5,8 @@
 
 from discord.ext import commands
 
+from cogs.voice import get_voice_manager
+
 import logging
 
 logger = logging.getLogger(__name__)
@@ -18,7 +20,8 @@ class Stop(commands.Cog):
     async def stop(self, ctx):
         await ctx.respond(content="\u200b", ephemeral=True)
         await ctx.interaction.delete_original_response()
-        await ctx.voice_client.disconnect()
+        voice_mgr = get_voice_manager(self.bot)
+        await voice_mgr.disconnect(ctx.guild)
         logger.info("Bot disconnected from voice channel")