# TODO

## Completed ✓

- [x] **Dev/release build config separation** - Store config next to binary in dev mode, use XDG in release mode.

- [x] **Volume without argument returns current volume** - `rsp volume` now returns current level.

- [x] **Fix SampleRate access in audio.rs:104** - `config.sample_rate().0` is invalid because `cpal::SampleRate` is a type alias for `u32`, not a tuple struct.

- [x] **Implement previous track logic** (`src/playback.rs:99`) - Implemented basic previous() that restarts current track if playing/paused.

- [x] **Remove unused std::thread import** (`src/playback.rs:2`) - Removed commented out import.

- [x] **Run clippy** - All linting checks pass.

- [x] **Run tests** - All tests pass.

- [x] **Check formatting** - Code formatting is correct.

- [x] **Implement resume functionality** - Implemented pause/resume using cpal stream pause()/play() methods.

- [x] **Fix audio playback speed and buffer underrun** - Implemented proper sample buffering between callbacks to prevent audio skipping and buffer underrun errors.

- [x] **Add Resume CLI subcommand** - Added `Resume` subcommand to CLI so users can resume playback after pause.

- [x] **Implement shuffle mode** - Added shuffle on/off/album functionality with queue management in daemon. Supports `rsp shuffle on/off/album` commands.

- [x] **Implement next/previous commands** - Next and previous track commands now work with the queue system.

- [x] **Queue entire directory** - When playing a folder, all audio files are now queued instead of just the first one.

- [x] **Auto-play next track** - Daemon automatically plays next track when current one ends (using `poll_track_ended()`).

- [x] **Queue display with pager** - `rsp queue` shows all queued tracks with pager support for long lists.

- [x] **Album shuffle mode structure** - `ShuffleMode::Album` added to enum and queue logic (behaves like `All` until database ready).

- [x] **Metadata extraction and display** - Extract ID3/metadata tags from audio files and display as "INDEX. ARTIST - TITLE", falls back to filename. Uses symphonia for metadata extraction.

- [x] **Flexible play command** - Added `-i/--now`, `-n/--next`, `-l/--last` flags to play command: `play MUSIC` (default - add to end and play), `play -i MUSIC` (insert after current and skip to it), `play -n MUSIC` (insert after current, don't skip), `play -l MUSIC` (add to end of queue). Also fixed queue display to correctly show playing track.

- [x] **Add unit tests for Player struct** - Tests added for Player, Track, PlaybackState, and ShuffleMode in `tests/playback.rs`.

- [x] **Database scan command** - Implemented `rsp scan` with `--force` full rescan and `--paths` override options. Uses symphonia for metadata extraction.

- [x] **Settings subcommands** - Implemented `rsp settings get/set/list/unset` for config management.

- [x] **Shell completions** - Generate shell completions with `rsp completions bash|elvish|fish|powershell|zsh`.

- [x] **Extract queue module** - Moved `Queue`, `Track`, `ShuffleMode`, `AudioMetadata` from daemon into `src/queue.rs` with public API and accessor methods.

- [x] **Comprehensive queue tests** - 34 tests covering navigation, shuffle, insert ordering, edge cases, and display.

- [x] **Fix queue/play bugs** - `rsp play <file>` no longer interrupts playback when something is already playing; directory `play -n`/`play -i` now inserts in correct order; removed dead duplicate shuffle handler; queue display no longer shows `(playing)` when playback is stopped.

- [x] **Systemd service unit** - Create systemd service file for auto-start.

- [x] **Desktop notifications** - Send notifications on track change, queue end, and errors via `notify-rust`.

- [x] **Shuffle first song** - `update_shuffle_indices` now shuffles all indices when position is 0; directory playback uses `q.current()` instead of `files.first()`.

## Remaining Work

### Phase 1: Play Command Rewrite

- [ ] **Rewrite `rsp play` behavior**
  - No options: Add to end of queue. If queue is empty AND player is in PLAY state, play immediately
  - `-i` / `--now`: Add after current track, then skip to it (insert + play)
  - `-n` / `--next`: Add after current track, don't skip
  - Remove `-l` / `--last` flag (redundant, it's default behavior)
  - Update CLI definitions in `src/cli.rs`
  - Update daemon handler in `src/daemon.rs`

### Phase 2: Queue Display Rewrite

- [ ] **Rewrite `rsp queue` behavior**
  - If queue rows <= terminal rows, display as-is (no pager needed)
  - If queue rows > terminal rows, pipe to pager (e.g., `less -R`)
  - Get terminal size using `terminal_size` crate or `ansi_term` / `crossterm`
  - Update queue display logic in `src/daemon.rs`

### Phase 3: Shuffle Rewrite

- [ ] **Rewrite shuffle mode**
  - Always remember original queue (add `original_tracks: Vec<Track>` field)
  - `rsp shuffle all`: Shuffle tracks after current position once, store original queue
  - `rsp shuffle none`: Restore from original queue - keep already-played tracks in place, insert unplayed tracks in original order after current position
  - `rsp shuffle album`: Shuffle tracks within each album's range separately (don't mix albums)
  - Update `Queue` struct in `src/queue.rs` with original queue storage
  - Update shuffle logic in `src/queue.rs` and daemon handlers in `src/daemon.rs`

### Phase 4: Optional Features

- [ ] **Persist queue state** - Save queue to disk so it survives daemon restarts.

- [ ] **Scrobbling (Last.fm/ListenBrainz)** - Add scrobbling support via configured credentials.

- [ ] **Customize status display** - Variables like $ARTIST, $ALBUM, $TRACK available in config so `queue`, `status` and notifs can be customized

- [ ] **Dynamic autocompletion of artists, albums and tracks** - Let shell communicate with the daemon so it returns autocompletions for shell