From ef2d8e354a91ef30e34e2ddb61381131a989591c Mon Sep 17 00:00:00 2001 From: salmonik Date: Sun, 1 Nov 2026 15:52:39 +0100 Subject: bins: read user args from argv[1..]; fix date year digit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit exec::spawn passes C-style argv with argv[0] = the command name, but ls, cat, mkdir, touch and rm treated argv[0] as their first user argument. Every path they were given resolved to the literal command name ("ls", "mkdir", ...), so they failed silently: `mkdir .../sub` never created the directory, `cat` printed nothing. date formatted its last year digit as `y as u8 % 10`, which truncates before the modulo (2026 -> 234 -> '4'), printing "2024". Only visible now that the system image actually stages /bin — before, /bin was empty and every command fell back to a built-in. --- bins/ls/src/main.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'bins/ls/src/main.rs') diff --git a/bins/ls/src/main.rs b/bins/ls/src/main.rs index 956bf18..b4acc41 100644 --- a/bins/ls/src/main.rs +++ b/bins/ls/src/main.rs @@ -16,8 +16,9 @@ fn put(exports: &rsapi::Exports, buf: &[u8]) { #[unsafe(no_mangle)] pub extern "C" fn efi_main(exports: &'static rsapi::Exports, argc: usize, argv: *const rsapi::Arg) -> i32 { - let path_str = if argc > 0 { - let a = unsafe { &*argv }; + // C-style argv: argv[0] is the program name, user args start at 1. + let path_str = if argc > 1 { + let a = unsafe { &*argv.add(1) }; unsafe { core::str::from_utf8_unchecked(core::slice::from_raw_parts(a.ptr, a.len)) } } else { "/" -- cgit v1.2.3