From 63d01e9d8eb6f3ccb6a96b7c577834276cf51add Mon Sep 17 00:00:00 2001
From: salmonik <salmonik@tuta.io>
Date: Sat, 1 Aug 2026 03:44:57 +0200
Subject: Clean up warnings, fix FAT32 multi-cluster dirs, prep for edition
 2024

Warning cleanup (cargo check + clippy now 0 across the workspace):
- Migrate all 21 static_mut_refs sites to &raw mut accessors (fat, gop,
  ps2, vt, ahci, interrupts, memory) so edition 2024 won't deny them
- panic = "abort" profiles: bare cargo check/build now works without
  nightly/-Zbuild-std
- Wire TICKS in the timer ISR (it was never incremented, so the vt scroll
  batching trigger was dead code)
- Clippy: efi_main becomes unsafe extern "efiapi" with a # Safety doc,
  KeyBuf::new uses inline-const array repeat (no interior-mutable const),
  editor main loop is a while-let, PIT control byte regrouped
- [workspace.lints.clippy] allows result_unit_err + needless_range_loop
  (deliberate kernel style); large_enum_variant allowed on LineInput
- Drop now-stale static_mut_refs allow from the rsdos bin

FAT32 correctness fixes (both pre-existing, exposed by the SFN fix):
- Unique 8.3 short names: to_8_3() never disambiguated collisions, so
  files sharing a long-name prefix got identical SFNs and fsck reported
  duplicate directory entries.  Add dir_short_names() + unique_short_name()
  (~N tails, Windows-style) and force LFN when the SFN changes.
- Multi-cluster directories: scan_dir/dir_short_names stopped at the first
  0x00 slot, hiding every entry written into a chained cluster (writes
  failed with 'cannot write', duplicate SFNs accumulated); add_dir_entry
  now packs the cluster (0xE5 deleted-markers) before extending so other
  FAT readers (mtools, Windows) see the continuation too.

Other: delete dead fields (Disk.fis, Volume.fat_count), drop timer_irq/
keyboard_irq/rendered, refresh_and_exit is a documented unsafe fn, CONTEXT
.md corrected (stable toolchain, IRQ input, 4-crate layout), .gitignore
excludes .pi-subagents artifacts.

Validated: cargo check/clippy/fmt clean, make test-disk PASS on fresh and
reused images (incl. two directory-chain extensions and ~10 SFN tails),
editor round-trip smoke test PASS.
---
 Cargo.toml | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

(limited to 'Cargo.toml')

diff --git a/Cargo.toml b/Cargo.toml
index cf18339..0cc785d 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -5,3 +5,19 @@ members = ["rsnix", "shell", "rsdos", "rsdosedit"]
 [workspace.package]
 version = "0.2.0"
 edition = "2021"
+
+# no_std UEFI kernel: no unwinder available, so panic must abort.
+# (Also makes bare `cargo check`/`cargo build` without --target work.)
+[profile.dev]
+panic = "abort"
+
+[profile.release]
+panic = "abort"
+
+# Deliberate kernel style, keep clippy quiet without rewriting hot paths:
+# - `Result<_, ()>` is the internal error idiom everywhere (fs/fat/ahci)
+# - indexed loops over static buffers are clearer in kernel code (and
+#   iterator rewrites would recreate `static_mut_refs` references)
+[workspace.lints.clippy]
+result_unit_err = "allow"
+needless_range_loop = "allow"
-- 
cgit v1.2.3